-
Notifications
You must be signed in to change notification settings - Fork 47
DOC-1569 Console new config for audit-logs #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-1569 Console new config for audit-logs #1346
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds documentation and sample configuration for a new Console audit log UI toggle. Updates include: introducing console.auditLog.enabled (default false) in the shared YAML attachment and in the Console configuration page examples; adding a note in the audit logging docs (non-cloud) describing how to view audit events by enabling the toggle; minor casing and formatting adjustments in docs. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
modules/console/pages/config/configure-console.adoc (1)
25-32: Optional: add env var mapping for the new key.Consider adding
console.auditLog.enabled → CONSOLE_AUDITLOG_ENABLEDto the mapping table to improve discoverability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
modules/console/pages/config/configure-console.adoc(5 hunks)modules/manage/partials/audit-logging.adoc(1 hunks)modules/shared/attachments/redpanda-console-config.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: run-tests (ubuntu-latest)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (3)
modules/manage/partials/audit-logging.adoc (1)
19-20: Good addition; link and key look correct.References
console.auditLog.enabled: trueand links to the right page. No issues.modules/shared/attachments/redpanda-console-config.yaml (1)
274-276: LGTM; correct placement and casing.
console.auditLog.enabled: falseis under theconsole:block with the right casing and a clear comment.modules/console/pages/config/configure-console.adoc (1)
214-215: Formatting fence count.Double-check the closing fence count around the include; ensure it matches the opening fence to avoid rendering glitches.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Martin Schneppenheim <[email protected]>
Feediver1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| brokers: ["redpanda-0:9092","redpanda-1:9092","redpanda-2:9092"] | ||
| auditLog: | ||
| enabled: false # default; set to true to write audit logs to stdout | ||
| additionalHeaders: # specifies HTTP headers to include in audit logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an example otherwise it's unclear how to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it defaults to: ["X-Forwarded-For", "User-Agent"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check me!
Description
This pull request adds how to enable audit logging in Redpanda Console. The changes add examples of the
auditLog.enabledconfiguration:auditLog.enabled: falseto YAML configuration examples inmodules/console/pages/config/configure-console.adocandmodules/shared/attachments/redpanda-console-config.yamlto demonstrate how to enable audit logging in Redpanda Console. [1] [2] [3]auditlog.enabled: falseunder thekafkasection in a YAML example to show audit logging configuration for Kafka brokers.modules/manage/partials/audit-logging.adocexplaining that users can view audit events in Redpanda Console by enabling audit logging withauditLog.enabled: true, with reference to the configuration documentation.Resolves https://redpandadata.atlassian.net/browse/DOC-1569
Review deadline:
Page previews
Configure Redpanda Console
Audit Loggings (conditionalized out for Cloud)
Checks